Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note in migration guide on camera lens intrinsics skew value change #1425

Merged
merged 1 commit into from
May 30, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 28, 2024

🦟 Bug fix

Summary

Add entry in migration guide to mention the camera lens intrinsics skew value change in #1423

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 28, 2024
@iche033 iche033 merged commit a21d28d into sdf14 May 30, 2024
8 checks passed
@iche033 iche033 deleted the migration_skew branch May 30, 2024 06:36
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants