Light: update calls to use sdf::Errors parameters

[marcoag]

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

🎉 New feature

Work towards #820.

Depends on: #1141.

Summary

Adds missing Errors structure parameters in a few methods of the Light class.

Test it

Using the Light class should report all errors through sdf::Errors if the errors parameter is used, it should print them otherwise.

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #1154 (3bec90b) into sdf13 (1d1f1d5) will decrease coverage by 0.03%.
The diff coverage is 96.88%.

❗ Current head 3bec90b differs from pull request most recent head ce487dd. Consider uploading reports for the commit ce487dd to get more accurate results

@@            Coverage Diff             @@
##            sdf13    #1154      +/-   ##
==========================================
- Coverage   87.51%   87.49%   -0.03%     
==========================================
  Files         126      126              
  Lines       16248    16388     +140     
==========================================
+ Hits        14220    14338     +118     
- Misses       2028     2050      +22     

Impacted Files	Coverage Δ
include/sdf/Plugin.hh	93.75% <ø> (ø)
src/Element.cc	96.21% <88.23%> (-1.01%)	⬇️
include/sdf/Element.hh	97.67% <95.23%> (-2.33%)	⬇️
python/src/sdf/pyError.cc	80.82% <100.00%> (+0.54%)	⬆️
src/Imu.cc	100.00% <100.00%> (ø)
src/JointAxis.cc	97.67% <100.00%> (+1.47%)	⬆️
src/Light.cc	93.13% <100.00%> (+0.34%)	⬆️
src/Noise.cc	96.09% <100.00%> (+0.26%)	⬆️
src/Plugin.cc	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[aaronchongth]

LGTM

[marcoag]

Added test for the sdf::Errors of the ToElement and Load methods.

[aaronchongth]

Thanks for adding the tests! LGTM