JointAxis: update calls to use sdf::Errors output #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2022 10:43
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
marcoag
force-pushed
the
marcoag/sdf_error_jointAxis
branch
from
b53d849
to
29a7e46
Compare
added 4 commits
March 22, 2023 11:43
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf13 #1145 +/- ##
==========================================
- Coverage 87.51% 87.47% -0.05%
==========================================
Files 126 126
Lines 16248 16363 +115
==========================================
+ Hits 14220 14313 +93
- Misses 2028 2050 +22
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aaronchongth
requested changes
Mar 23, 2023
added 2 commits
March 23, 2023 12:22
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
aaronchongth
requested changes
Mar 24, 2023
src/JointAxis.cc
Outdated
| limitElem->GetElement("dissipation")->Set<double>(this->Dissipation()); | ||
| sdf::ElementPtr dynElem = axisElem->GetElement("dynamics", _errors); | ||
| dynElem->GetElement("damping", _errors)->Set<double>( | ||
| this->Damping()); |
There was a problem hiding this comment.
Sorry I didn't notice this last review, I think you might have missed using the new overloaded function with errors here
src/JointAxis.cc
Outdated
| dynElem->GetElement("damping", _errors)->Set<double>( | ||
| this->Damping()); | ||
| dynElem->GetElement("friction", _errors)->Set<double>( | ||
| this->Friction()); |
There was a problem hiding this comment.
Same for this line as well
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
aaronchongth
requested changes
Mar 28, 2023
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
aaronchongth
approved these changes
Mar 28, 2023
marcoag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco A. Gutierrez marco@openrobotics.org
🎉 New feature
Work towards #820.
Depends on: #1141.
Summary
Adds missing
Errorsstructure parameters in a few methods of the JointAxis class.Test it
Using the JointAxis class should report all errors through
sdf::Errorsif theerrorsparameter is used, it should print them otherwise.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.