Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Param: update calls to use sdf::Errors parameters #1140

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Param: update calls to use sdf::Errors parameters #1140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2c90ff
update Param calls to use error vectors parameters
Sep 14, 2022
9dc7e89
Merge branch 'sdf13' into marcoag/sdf_error_param_update
Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Param.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1473,7 +1473,7 @@ bool Param::ValidateValue(sdf::Errors &_errors) const
std::ostringstream oss;
oss << "The value [" << _val
<< "] is less than the minimum allowed value of ["
<< *this->GetMinValueAsString() << "] for key ["
<< *this->GetMinValueAsString(_errors) << "] for key ["
<< this->GetKey() << "]";
_errors.push_back({ErrorCode::PARAMETER_ERROR, oss.str()});
return false;
Expand All @@ -1486,7 +1486,7 @@ bool Param::ValidateValue(sdf::Errors &_errors) const
std::ostringstream oss;
oss << "The value [" << _val
<< "] is greater than the maximum allowed value of ["
<< *this->GetMaxValueAsString() << "] for key ["
<< *this->GetMaxValueAsString(_errors) << "] for key ["
<< this->GetKey() << "]";
_errors.push_back({ErrorCode::PARAMETER_ERROR, oss.str()});
return false;
Expand Down