Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param: update calls to use sdf::Errors parameters #1140

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Sep 15, 2022

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

🎉 New feature

Work towards #820.

Summary

Adds missing Errors structure parameters in a few calls on the Param class.

Test it

Using the Param class should report all errors through sdf::Errors.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1140 (9dc7e89) into sdf13 (c8782e7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            sdf13    #1140   +/-   ##
=======================================
  Coverage   87.20%   87.20%           
=======================================
  Files         124      124           
  Lines       16229    16229           
=======================================
  Hits        14152    14152           
  Misses       2077     2077           
Impacted Files Coverage Δ
src/Param.cc 87.78% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marcoag marcoag changed the title update Param calls to use error vectors parameters Param: update calls to use sdf::Errors parameters Sep 15, 2022
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@marcoag marcoag changed the base branch from main to sdf13 October 3, 2022 10:23
@marcoag marcoag force-pushed the marcoag/sdf_error_param_update branch from f1acc8d to e2c90ff Compare October 3, 2022 10:24
@marcoag marcoag merged commit fd19351 into sdf13 Dec 15, 2022
@marcoag marcoag deleted the marcoag/sdf_error_param_update branch December 15, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants