Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ign-common3 ➡️ ign-common4 #500

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Merge ign-common3 ➡️ ign-common4 #500

merged 2 commits into from
Mar 30, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Mar 30, 2023

➡️ Forward port

Port ign-common3 ➡️ ign-common4

Branch comparison: ign-common4...ign-common3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

ahcorde and others added 2 commits March 30, 2023 11:53
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from marcoag as a code owner March 30, 2023 16:57
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #500 (36a17bb) into ign-common4 (5e97e6c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 36a17bb differs from pull request most recent head 0fd1f5e. Consider uploading reports for the commit 0fd1f5e to get more accurate results

@@             Coverage Diff              @@
##           ign-common4     #500   +/-   ##
============================================
  Coverage        82.85%   82.86%           
============================================
  Files               75       75           
  Lines             9556     9558    +2     
============================================
+ Hits              7918     7920    +2     
  Misses            1638     1638           
Impacted Files Coverage Δ
graphics/src/MeshManager.cc 86.65% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey azeey merged commit 0297942 into ign-common4 Mar 30, 2023
@azeey azeey deleted the azeey/3_to_4 branch March 30, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants