Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www): remove unused #9780

Merged
merged 1 commit into from
Nov 7, 2018
Merged

fix(www): remove unused #9780

merged 1 commit into from
Nov 7, 2018

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Nov 7, 2018

We will be getting those for a while :( (as PR that remove usage was used on branch before the linting change). This currently fails linting, because Link is defined but not used

@pieh pieh requested a review from a team as a code owner November 7, 2018 13:41
Copy link
Contributor

@fk fk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ay ay ay, missed that when editing #9767. Thanks @pieh! 🙏

@pieh pieh merged commit f545a23 into gatsbyjs:master Nov 7, 2018
@pieh pieh deleted the remove-unused branch November 7, 2018 14:53
pieh added a commit that referenced this pull request Nov 7, 2018
seems like current (bit whacky) patterns don't play nice on windows for some reason, let's try different ones

note - there is currently unrelated lint error in `www` so linting should fail - but it should have 1 error instead of thousands of errors on azure/appveyor - with this #9780 should be clear
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
We will be getting those for a while :( (as PR that remove usage was used on branch before the linting change). This currently fails linting, because `Link` is defined but not used
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
seems like current (bit whacky) patterns don't play nice on windows for some reason, let's try different ones

note - there is currently unrelated lint error in `www` so linting should fail - but it should have 1 error instead of thousands of errors on azure/appveyor - with this gatsbyjs#9780 should be clear
@pieh pieh restored the remove-unused branch May 17, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants