Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(www): add webinar link/banner #9767

Merged
merged 4 commits into from
Nov 7, 2018

Conversation

amberleyromo
Copy link
Contributor

Feature upcoming webinar on banner.

@amberleyromo amberleyromo requested a review from a team November 7, 2018 02:20
@amberleyromo amberleyromo requested a review from a team as a code owner November 7, 2018 02:20
@amberleyromo amberleyromo requested a review from fk November 7, 2018 02:21
@amberleyromo
Copy link
Contributor Author

@fk this is a quick stopgap to promote the webinar. Right now it doesn't scale down nicely -- if you want to take a look at this, please feel free to merge on approval / after making whatever quick changes you want.

@DSchau DSchau changed the title Feat/feature webinar on banner feat(www): add webinar link/banner Nov 7, 2018
@fk
Copy link
Contributor

fk commented Nov 7, 2018

Right now it doesn't scale down nicely

You mean the overflow scroll?

whatever quick changes you want.

Fixed quote marks and chose to remove the "fallback" content in banner.js. I think marking the prop as required in addition to the check if children is defined is good enough.

@fk fk merged commit d944be3 into gatsbyjs:master Nov 7, 2018
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
* change banner text to promote webinar

* add link to v1 docs in migration guide

* Fix quotation marks

* Rm „fallback“ banner content, mark prop as required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants