Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix failing path prefix test by updating gatsby/cli version #8362

Merged
merged 2 commits into from
Sep 21, 2018
Merged

test: fix failing path prefix test by updating gatsby/cli version #8362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11c9105
test: fix failing path prefix test by updating gatsby/cli version
DSchau Sep 20, 2018
8ee59ba
ci: don't hardcode gatsby path
DSchau Sep 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration-tests/path-prefix/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"author": "Kyle Mathews <mathews.kyle@gmail.com>",
"dependencies": {
"cypress": "^3.1.0",
"gatsby": "next",
"gatsby": "^2.0.6",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be latest 🙃

"gatsby-plugin-manifest": "next",
"gatsby-plugin-offline": "next",
"gatsby-plugin-react-helmet": "next",
Expand Down
5 changes: 3 additions & 2 deletions scripts/integration-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
#!/bin/bash
SRC_PATH=$1
CUSTOM_COMMAND="${2:-test}"
GATSBY_PATH="/home/circleci/project"
GATSBY_PATH="${CIRCLE_WORKING_DIRECTORY:-../../}"

sudo npm install -g gatsby-dev-cli &&

# setting up child integration test link to gatsby packages
cd $SRC_PATH &&
yarn &&
gatsby-dev --set-path-to-repo $GATSBY_PATH &&
gatsby-dev --scan-once --copy-all && # copies _all_ files in gatsby/packages
gatsby-dev --scan-once --copy-all --quiet && # copies _all_ files in gatsby/packages
sudo chmod +x ./node_modules/.bin/gatsby && # this is sometimes necessary to ensure executable
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I should maybe make this change at the gatsby-dev-cli level, instead, but this works for now.

Does anyone else run into this? I can replicate it pretty reliably on my local machine 🙃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh really? I've never hit that problem — I thought NPM took care of that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's replicated in that test I linked to too to the best of my knowledge. Weird stuff 😱

yarn $CUSTOM_COMMAND &&
echo "Integration test run succeeded"