test: fix failing path prefix test by updating gatsby/cli version #8362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the internal gatsby version in one of the tests (path prefix) so that the `gatsby serve` command now has the option `--prefix-paths` which is required for the test to pass. To the best of my knowledge, the --copy-all behavior of gatsby-dev-cli isn't meaningful here, because it doesn't copy over the .bin executables, so the local package.json versions are still used for some things. Also note, for the chmod change, check out [this test run](https://circleci.com/gh/gatsbyjs/gatsby/1410). I've seen that happen locally after running gatsby-dev-cli, and that's the fix that's worked for me!
DSchau
commented
Sep 20, 2018
|
|
||
| sudo npm install -g gatsby-dev-cli && | ||
|
|
||
| # setting up child integration test link to gatsby packages | ||
| cd $SRC_PATH && | ||
| yarn && | ||
| gatsby-dev --set-path-to-repo $GATSBY_PATH && | ||
| gatsby-dev --scan-once --copy-all && # copies _all_ files in gatsby/packages | ||
| gatsby-dev --scan-once --copy-all --quiet && # copies _all_ files in gatsby/packages | ||
| sudo chmod +x ./node_modules/.bin/gatsby && # this is sometimes necessary to ensure executable |
There was a problem hiding this comment.
Note: I should maybe make this change at the gatsby-dev-cli level, instead, but this works for now.
Does anyone else run into this? I can replicate it pretty reliably on my local machine 🙃
There was a problem hiding this comment.
huh really? I've never hit that problem — I thought NPM took care of that
There was a problem hiding this comment.
Yeah, it's replicated in that test I linked to too to the best of my knowledge. Weird stuff 😱
DSchau
commented
Sep 20, 2018
| @@ -5,7 +5,7 @@ | |||
| "author": "Kyle Mathews <mathews.kyle@gmail.com>", | |||
| "dependencies": { | |||
| "cypress": "^3.1.0", | |||
| "gatsby": "next", | |||
| "gatsby": "^2.0.6", | |||
There was a problem hiding this comment.
This should probably be latest 🙃
pieh
approved these changes
Sep 21, 2018
|
@pieh sounds good, thanks for the merge! |
oorestisime
pushed a commit
to oorestisime/gatsby
that referenced
this pull request
Sep 28, 2018
…tsbyjs#8362) * test: fix failing path prefix test by updating gatsby/cli version This updates the internal gatsby version in one of the tests (path prefix) so that the `gatsby serve` command now has the option `--prefix-paths` which is required for the test to pass. To the best of my knowledge, the --copy-all behavior of gatsby-dev-cli isn't meaningful here, because it doesn't copy over the .bin executables, so the local package.json versions are still used for some things. Also note, for the chmod change, check out [this test run](https://circleci.com/gh/gatsbyjs/gatsby/1410). I've seen that happen locally after running gatsby-dev-cli, and that's the fix that's worked for me! * ci: don't hardcode gatsby path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the internal gatsby version in one of the tests (path
prefix) so that the
gatsby servecommand now has the option--prefix-pathswhich is required for the test to pass. To the best ofmy knowledge, the --copy-all behavior of gatsby-dev-cli isn't meaningful
here, because it doesn't copy over the .bin executables, so the local
package.json versions are still used for some things.
Also note, for the chmod change, check out this test run. I've seen that happen locally after running gatsby-dev-cli, and that's the fix that's worked for me!