Revert "fix(assert-changed-files): don't skip running tests on master" #28408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #28400
That seemed to cause very weird issues for windows tests for PRs that don't contain the change itself ( see https://app.circleci.com/pipelines/github/gatsbyjs/gatsby/54414/workflows/4c08227f-9226-42e7-b8bb-1532a7ae15a2/jobs/570991 for example ):
It leaves the dir with mess:
and executes tests that are not in the PR branch but are on
master
branch ...This needs to be solved properly in different ways - probably better way of getting list of changed files than merging anything in (why even make changes to current working directory in this script?)