Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assert-changed-files): don't skip running tests on master #28400

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Dec 1, 2020

Description

Our script asserting if anything related changed has flaw that it never allow tests to run on master - because it compares current branch to master and master compared to master shows no changes ;)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 1, 2020
@pieh pieh added topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 1, 2020
@pieh pieh merged commit 5812c81 into master Dec 1, 2020
@pvdz pvdz added topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot and removed topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot labels Dec 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the dont-skip-tests-on-master branch December 1, 2020 09:14
pieh added a commit that referenced this pull request Dec 1, 2020
pieh added a commit that referenced this pull request Dec 1, 2020
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants