Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Create gitlab-continuous-integration.md #23367

Merged
merged 10 commits into from
Apr 22, 2020

Conversation

puzzledbytheweb
Copy link
Contributor

Description

Adds a small recipe with a minimal example on how to setup gitlab ci/cd for a gatsby project

A small recipe with a minimal example on how to setup gitlab ci/cd for a gatsby project
@puzzledbytheweb puzzledbytheweb requested a review from a team as a code owner April 22, 2020 08:50
@puzzledbytheweb puzzledbytheweb changed the title Create gitlab-continuous-integration.md docs: Create gitlab-continuous-integration.md Apr 22, 2020
@laurieontech laurieontech added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Apr 22, 2020
Copy link
Contributor

@Ekwuno Ekwuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this in. I have tested it and it checks out . I added a few suggestions in the submission.

docs/docs/recipes/gitlab-continuous-integration.md Outdated Show resolved Hide resolved
docs/docs/recipes/gitlab-continuous-integration.md Outdated Show resolved Hide resolved
docs/docs/recipes/gitlab-continuous-integration.md Outdated Show resolved Hide resolved
@Ekwuno Ekwuno self-assigned this Apr 22, 2020
@Ekwuno Ekwuno added the status: awaiting author response Additional information has been requested from the author label Apr 22, 2020
puzzledbytheweb and others added 3 commits April 22, 2020 15:48
Copy link
Contributor

@Ekwuno Ekwuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few more suggestions

docs/docs/recipes/gitlab-continuous-integration.md Outdated Show resolved Hide resolved
docs/docs/recipes/gitlab-continuous-integration.md Outdated Show resolved Hide resolved
puzzledbytheweb and others added 2 commits April 22, 2020 16:54
Co-Authored-By: Obinna Ekwuno  <obinnacodes@gmail.com>
Co-Authored-By: Obinna Ekwuno  <obinnacodes@gmail.com>
@Ekwuno Ekwuno merged commit 5035fd9 into gatsbyjs:master Apr 22, 2020
@gatsbot
Copy link

gatsbot bot commented Apr 22, 2020

Holy buckets, @puzzledbytheweb — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@puzzledbytheweb puzzledbytheweb deleted the patch-1 branch April 23, 2020 07:24
pvhee added a commit to marzeelabs/gatsby that referenced this pull request Apr 24, 2020
* 'master' of github.com:gatsbyjs/gatsby: (64 commits)
  Fix recipe test problems (gatsbyjs#23347)
  create blog post announcing extended deadline for Virtual Gatsby Days… (gatsbyjs#23430)
  Correct CFP deadline date on Virtual Gatsby Days registration announcement (gatsbyjs#23432)
  fix(gatsby-recipes): Raise an error when an unknown resource is used (gatsbyjs#23428)
  feat(gatsby-recipes): While apply a step, show the time elapsed after 10 seconds (gatsbyjs#23362)
  markdownASTToHTMLAst isn't async (gatsbyjs#23427)
  Be more vocal about not doing type checking (gatsbyjs#23397)
  docs(gatsby-remark-images): mark `sizeByPixelDensity` as deprecated (gatsbyjs#23387)
  chore(all): Improve renovate (gatsbyjs#23411)
  chore(gatsby): count sift hits in telemetry (gatsbyjs#23416)
  chore(showcase): add GeneOS and COVID KPI (gatsbyjs#23405)
  feat(analytics): defer google analytics script (gatsbyjs#22806)
  docs: mention passing the .tsx file to createPage (gatsbyjs#23329)
  fix(www): tweak docsearch to init algolia when tabbed into (gatsbyjs#23040)
  chore(docs): Fix typo in url (gatsbyjs#23394)
  chore(gatsby-preset-gatsby-package): Remove tsconfig.json (gatsbyjs#23388)
  fix(gatsby-recipes): link to the raw gist of .estlintrc.js (gatsbyjs#23390)
  docs: Create gitlab-continuous-integration.md (gatsbyjs#23367)
  chore(doc): switch zeit now to Vercel Now for Gatsby deployment (gatsbyjs#23346)
  chore(showcase): add Resume on the Web (gatsbyjs#23371)
  ...
@muescha
Copy link
Contributor

muescha commented May 22, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting author response Additional information has been requested from the author type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants