Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): switch zeit now to Vercel Now for Gatsby deployment #23346

Merged
merged 9 commits into from
Apr 22, 2020

Conversation

Developerayo
Copy link
Contributor

@Developerayo Developerayo commented Apr 21, 2020

  • Zeit just rebranded to Vercel and this PR changes the deployment guidelines for deploying Gatsby to Vercel Now
  • Now still remains Now but ZEIT is no longer zeit but Vercel as of today

- Zeit just rebranded to now and this PR changes the deployment guidelines for deploying Gatsby to `Vercel Now`
- Now still remains Now but ZEIT is no longer zeit but `Vercel` as of today
[FIX] switch zeit now to Vercel Now for Gatsby deployment
@Developerayo Developerayo requested a review from a team as a code owner April 21, 2020 12:55
@Ekwuno Ekwuno changed the title [FIX] switch zeit now to Vercel Now for Gatsby deployment chore(doc): switch zeit now to Vercel Now for Gatsby deployment Apr 22, 2020
Copy link
Contributor

@Ekwuno Ekwuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Developerayo Thanks for sending in these updates. I left a few suggestions in the PR. I would ask that you leave the sections on getting started with Gatsby and the steps as they are. Maybe update only the parts that have been updated via https://vercel.com/guides/deploying-gatsby-with-vercel

docs/docs/deploying-to-now.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-now.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-now.md Outdated Show resolved Hide resolved
@Ekwuno Ekwuno self-assigned this Apr 22, 2020
@Ekwuno Ekwuno added status: awaiting author response Additional information has been requested from the author type: documentation An issue or pull request for improving or updating Gatsby's documentation labels Apr 22, 2020
Developerayo and others added 2 commits April 22, 2020 15:06
Co-Authored-By: Obinna Ekwuno  <obinnacodes@gmail.com>
@Developerayo Developerayo requested a review from Ekwuno April 22, 2020 14:11
Copy link
Contributor

@Ekwuno Ekwuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks.

Copy link
Contributor

@lannonbr lannonbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave some suggestions. This isn't ready to be merged just yet

docs/docs/deploying-to-now.md Show resolved Hide resolved
docs/docs/deploying-to-now.md Show resolved Hide resolved
Copy link
Contributor

@Ekwuno Ekwuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly update your fork of the Gatsby repo, it's 6500 commits behind the master. That would explain why you have some files that no longer exist.

@Ekwuno
Copy link
Contributor

Ekwuno commented Apr 22, 2020

Gave some suggestions. This isn't ready to be merged just yet

Yes! I just checked

@Developerayo
Copy link
Contributor Author

Updated fork from upstream...

Copy link
Contributor

@Ekwuno Ekwuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one more change request. Thanks for your patience.

docs/docs/deploying-to-now.md Show resolved Hide resolved
@Ekwuno Ekwuno merged commit b8976c7 into gatsbyjs:master Apr 22, 2020
pvhee added a commit to marzeelabs/gatsby that referenced this pull request Apr 24, 2020
* 'master' of github.com:gatsbyjs/gatsby: (64 commits)
  Fix recipe test problems (gatsbyjs#23347)
  create blog post announcing extended deadline for Virtual Gatsby Days… (gatsbyjs#23430)
  Correct CFP deadline date on Virtual Gatsby Days registration announcement (gatsbyjs#23432)
  fix(gatsby-recipes): Raise an error when an unknown resource is used (gatsbyjs#23428)
  feat(gatsby-recipes): While apply a step, show the time elapsed after 10 seconds (gatsbyjs#23362)
  markdownASTToHTMLAst isn't async (gatsbyjs#23427)
  Be more vocal about not doing type checking (gatsbyjs#23397)
  docs(gatsby-remark-images): mark `sizeByPixelDensity` as deprecated (gatsbyjs#23387)
  chore(all): Improve renovate (gatsbyjs#23411)
  chore(gatsby): count sift hits in telemetry (gatsbyjs#23416)
  chore(showcase): add GeneOS and COVID KPI (gatsbyjs#23405)
  feat(analytics): defer google analytics script (gatsbyjs#22806)
  docs: mention passing the .tsx file to createPage (gatsbyjs#23329)
  fix(www): tweak docsearch to init algolia when tabbed into (gatsbyjs#23040)
  chore(docs): Fix typo in url (gatsbyjs#23394)
  chore(gatsby-preset-gatsby-package): Remove tsconfig.json (gatsbyjs#23388)
  fix(gatsby-recipes): link to the raw gist of .estlintrc.js (gatsbyjs#23390)
  docs: Create gitlab-continuous-integration.md (gatsbyjs#23367)
  chore(doc): switch zeit now to Vercel Now for Gatsby deployment (gatsbyjs#23346)
  chore(showcase): add Resume on the Web (gatsbyjs#23371)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting author response Additional information has been requested from the author type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants