feat(relay): use relay-compiler v5, fix #11536 #15963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly Relay have regressed on the bugs that we fixed in their code, Relay should be fixed before we can use it. |
|
is there an issue there about it? |
|
@sibelius Not sure about an issue there at the moment but I think @freiksenet is referring to the fixes he made in facebook/relay#2638. @freiksenet Want to add a test asserting the behaviour that we depend on to better track this? Closing this in the mean time but thank you for opening this @sibelius and apologies for the confusion here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses relay-compiler v5 instead of gatsby fork
Related Issues
#11536
I've tried to run all tests locally, but there are a lot of them breaking (yarn jest)