-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gatsby: Don't use fork of relay-compiler #11536
Comments
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open! Thanks for being a part of the Gatsby community! 💪💜 |
Fixed in latest relay, should be tested and used. |
Not fixed in Relay, we are still using Relay fork. Modifying the issue to be about that. |
Should this switch from:
to:
or a different version? See here for a similar PR if anyone would like to take this on. |
Last time we patched this, it broke our builds because Relay regressed. I'll assign myself and try it again when I have time. |
Currently, it shows security alert with |
So far this is impossible, because relay-compiler has completely broken compatibility with Gatsby, eg by not supporting complex input types. We will keep using forked relay-compiler. https://github.com/facebook/relay/blob/master/packages/relay-compiler/core/RelayParser.js#L1392 I'll release an update to forked compiler with this library fixed. Closing this issue because we will keep using fork in near future. |
now it does support complex input types |
@freiksenet Any interest in re-evaluating? I'm not sure exactly when you forked, but we've continually worked to improve Relay Compiler performance (especially in the last 6 months) that could potentially benefit Gatsby users. |
Description
When having literal enums that have non-string values (eg ImageCropFocus), Relay fails to print the query.
Expected result
Should print normally.
Actual result
Fails with exception.
Reported upstream in facebook/relay#2633.
We should consider downgrading back to relay-compiler 1.
The text was updated successfully, but these errors were encountered: