Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback DANGEROUSLY_DISABLE_OOM #14767

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Rollback DANGEROUSLY_DISABLE_OOM #14767

merged 2 commits into from
Jun 13, 2019

Conversation

abhijithvijayan
Copy link
Contributor

Description

Rollback feat(gatsby): add DANGEROUSLY_DISABLE_OOM #13066

Related Issues

Fixes #13284

@abhijithvijayan abhijithvijayan requested a review from a team as a code owner June 13, 2019 09:58
@abhijithvijayan abhijithvijayan requested review from a team and wardpeet June 13, 2019 09:58
@wardpeet wardpeet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 13, 2019
wardpeet
wardpeet approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇! Thanks for removing this feature as this isn't necessary anymore.

No comments, well done! 👏

@wardpeet wardpeet merged commit cad6861 into gatsbyjs:master Jun 13, 2019
mxxk pushed a commit to mxxk/gatsby that referenced this pull request Jun 21, 2019
@abhijithvijayan @mxxk
Rollback DANGEROUSLY_DISABLE_OOM (gatsbyjs#14767)
2d10d28
@ganapativs ganapativs mentioned this pull request Aug 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rollback DANGEROUSLY_DISABLE_OOM when V8.serialize is merged
2 participants
@abhijithvijayan @wardpeet