Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback DANGEROUSLY_DISABLE_OOM when V8.serialize is merged #13284

Closed
wardpeet opened this issue Apr 11, 2019 · 2 comments · Fixed by #14767
Closed

Rollback DANGEROUSLY_DISABLE_OOM when V8.serialize is merged #13284

wardpeet opened this issue Apr 11, 2019 · 2 comments · Fixed by #14767
Labels
good first issue Issue that doesn't require previous experience with Gatsby type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@wardpeet
Copy link
Contributor

Summary

A quick fix to enable gatsby users to disable redux state caching was introduced by #13066 as it caused out of memory issues for large websites. #10732 fixes this issue correctly by moving away from json-stringify into v8.serialize.

#10732 still keeps the redux state on disk which gives us the same speed benefits as we had before. With the temporary fix, we didn't have any cache which means our site takes more time to load.
@wardpeet wardpeet added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change no triage not stale labels Apr 11, 2019
@lannonbr
Copy link
Contributor

As the v8.serialize PR was merged, I believe this can be tackled now

@wardpeet wardpeet added the good first issue Issue that doesn't require previous experience with Gatsby label Jun 13, 2019
@abhijithvijayan
Copy link
Contributor

abhijithvijayan commented Jun 13, 2019 •
edited
Loading

@wardpeet @lannonbr I can take a shot at this. All I have to do is rollback #13066 right?

@abhijithvijayan abhijithvijayan mentioned this issue Jun 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issue that doesn't require previous experience with Gatsby type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rollback DANGEROUSLY_DISABLE_OOM abhijithvijayan/gatsby
4 participants
@wardpeet @lannonbr @LekoArts @abhijithvijayan