fix(gatsby-plugin-netlify-cms): Add uglifyjs-webpack-plugin to dependencies #10149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to switch the plugin we're testing for, it's now terser instead of uglify (#10067 (comment)). I'm now considering finding a better approach than instance checking. |
|
Thank @erquhart for taking over. I'll close this one. |
pieh
pushed a commit
that referenced
this pull request
Nov 27, 2018
Closes #10067. Replaces #10149. Webpack started using terser instead of uglify, which broke our plugin's check for the uglify webpack plugin (to exclude it from our pipeline). But it seems that excluding terser isn't even necessary, can't find any bugs in dev or prod builds. The remaining plugin that needs to be avoided will be handled by name rather than instance. cc/ @pieh
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
…byjs#10150) Closes gatsbyjs#10067. Replaces gatsbyjs#10149. Webpack started using terser instead of uglify, which broke our plugin's check for the uglify webpack plugin (to exclude it from our pipeline). But it seems that excluding terser isn't even necessary, can't find any bugs in dev or prod builds. The remaining plugin that needs to be avoided will be handled by name rather than instance. cc/ @pieh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10067