Skip to content

Commit

Permalink
fix(gatsby-plugin-netlify-cms): fix uglify webpack plugin check (#10150)
Browse files Browse the repository at this point in the history
Closes #10067.
Replaces #10149.

Webpack started using terser instead of uglify, which broke our plugin's check for the uglify webpack plugin (to exclude it from our pipeline). But it seems that excluding terser isn't even necessary, can't find any bugs in dev or prod builds.

The remaining plugin that needs to be avoided will be handled by name rather than instance.

cc/ @pieh
  • Loading branch information
erquhart authored and pieh committed Nov 27, 2018
1 parent 288d928 commit b1101f5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/gatsby-plugin-netlify-cms/src/gatsby-node.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import webpack from "webpack"
import HtmlWebpackPlugin from "html-webpack-plugin"
import HtmlWebpackExcludeAssetsPlugin from "html-webpack-exclude-assets-plugin"
import MiniCssExtractPlugin from "mini-css-extract-plugin"
import UglifyJsPlugin from "uglifyjs-webpack-plugin"
import FriendlyErrorsPlugin from "friendly-errors-webpack-plugin"

/**
Expand Down Expand Up @@ -83,8 +82,9 @@ exports.onCreateWebpackConfig = (
*/
...gatsbyConfig.plugins.filter(
plugin =>
![UglifyJsPlugin, MiniCssExtractPlugin, FriendlyErrorsPlugin].find(
Plugin => plugin instanceof Plugin
![`MiniCssExtractPlugin`].find(
pluginName =>
plugin.constructor && plugin.constructor.name === pluginName
)
),

Expand Down

0 comments on commit b1101f5

Please sign in to comment.