Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www/showcase] Make category filter "accordion" responsive #6724

Closed
fk opened this issue Jul 24, 2018 · 1 comment · Fixed by #6838
Closed

[www/showcase] Make category filter "accordion" responsive #6724

fk opened this issue Jul 24, 2018 · 1 comment · Fixed by #6838
Assignees

Comments

@fk
Copy link
Contributor

fk commented Jul 24, 2018

Currently the height of the accordion component containing the "Category" filters/checkboxes is hardcoded to 500px: https://github.com/gatsbyjs/gatsby/blob/master/www/src/views/showcase/collabsible.js#L45-L60

This can result in the accordion not being fully visible. Making one accordion responsive should be easy; however as we might want to add a second accordion (and already do so in the Starter Showcase (#5334), we should investigate how to make a reasonable set (2~5) of accordions responsive. If I'm not totatlly off, flexbox should get us there without additional JS.

Sidenote: If only showing one accordion, do we ever need/should we allow to collapse it?

@swyxio
Copy link
Contributor

swyxio commented Jul 26, 2018

this has helped me today: using flexbox with overflow-y: scroll isnt a well documented thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants