Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] v1.5 Site Showcase - cleanup #7488

Closed
1 of 9 tasks
shannonbux opened this issue Aug 20, 2018 · 13 comments
Closed
1 of 9 tasks

[EPIC] v1.5 Site Showcase - cleanup #7488

shannonbux opened this issue Aug 20, 2018 · 13 comments
Labels
stale? Issue that may be closed soon due to the original author not responding any more.

Comments

@shannonbux
Copy link
Contributor

shannonbux commented Aug 20, 2018

Epic Template

Who will own this?

Area of Responsibility:

Select the Area of Responsibility most impacted by this Epic

  • Community

  • Learning

  • Ecosystem

  • Gatsby Core

  • Enterprise

  • Design

  • Marketing

  • Company/Admin

  • Sales

    AoR owner @amberleyromo
    Domain owner @name
    Project manager @name
    Tech lead @name
    Contributors @name

Summary

We need to clean up a few bugs happening with the site showcase so the user experience is smoother.

How will this impact Gatsby?

Domains

.org website

Components

List the impacted Components here

Goals

  1. Reduce the number of bugs with the site showcase

How will we know this epic is a success?

What changes must we see, or what must be created for us to know the project was a success. How will we know when the project is done? How will we measure success?

User Can Statement

  • User can find the tags they are looking for
  • User can view beautiful screenshots, no matter what language is on the screenshot
  • User can experience a fast website, which probably requires pagination in the site showcase

Metrics to Measure Success

  • Decrease in number of bugs

Additional Description

MVP

Here's what we already finished in Issue #4392:

What are the risks to the epic?

The risks of organizing this partially in the [EPIC] v2, [EPIC] v2 UX & docs, and this epic, could lead to confusion and mis-prioritization and even duplicate work.

What questions do we still need to answer, or what resources do we need?

Need to assign a tech lead and contributors.

How will we complete the epic?

  • Need to assign a tech lead and contributors
  • Need to decide whether site showcase bugs and requests go here or in [EPIC] v2 or [EPIC] v2 UX & docs
  • Need to place this in the roadmap in the correct order
  • Have a kickoff meeting when we start working on this Epic

How else could we accomplish the same goal?

Nope!

@calcsam calcsam changed the title [EPIC] Site Showcase cleanup [EPIC] v1.5 Site Showcase -- cleanup Aug 21, 2018
@shannonbux
Copy link
Contributor Author

@fk do you remember what this means?

when a filter is selected any category that is not related to any sites left by the filter should be hidden, as selecting them would have no effect on the state of the page

@fk
Copy link
Contributor

fk commented Aug 23, 2018

I think this is related to a different filtering logic (than the one we went for and is live on https://next.gatsbyjs.org/showcase/):
Given two categories a and b, and 10 total sites of which

  • 2 sites are in category a and b
  • 4 sites are just in category a
  • 4 sites are just in category b
  • = a total of 5 sites in category a and b each

the sidebar filters initially would look like this

  • ( ) category a 5
  • ( ) category b 5

and all 10 sites being displayed.
then selecting "category a" would

  • result in the 5 sites in category a being shown
  • the sidebar filters to update like this:
    • (x) category a 5
    • ( ) category b 2
      …with the count for all unselected category filters being updated to reflect the intersection of the selected category and the unselected category -- selecting "category b" now would result in the site list updating to just show sites in both category a and b (and raising the question "what should the count for each category reflect now? :-D)…

Bottom line: We went for "unity" instead of "intersection", so we can safely forget about

when a filter is selected any category that is not related to any sites left by the filter should be hidden, as selecting them would have no effect on the state of the page

@shannonbux shannonbux assigned shannonbux and unassigned fk and calcsam Aug 24, 2018
@shannonbux shannonbux changed the title [EPIC] v1.5 Site Showcase -- cleanup [EPIC] v1.5 Site Showcase - cleanup Aug 24, 2018
@calcsam calcsam added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Aug 29, 2018
@shannonbux shannonbux removed their assignment Sep 21, 2018
@shannonbux shannonbux removed type: documentation An issue or pull request for improving or updating Gatsby's documentation 🎯 Learning labels Sep 21, 2018
@gatsbot
Copy link

gatsbot bot commented Jan 14, 2019

Old issues will be closed after 30 days of inactivity. This issue has been quiet for 20 days and is being marked as stale. Reply here or add the label "not stale" to keep this issue open!

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 14, 2019
@gatsbot
Copy link

gatsbot bot commented Jan 25, 2019

This issue is being closed due to inactivity. Is this a mistake? Please re-open this issue or create a new issue.

@gatsbot gatsbot bot closed this as completed Jan 25, 2019
@amberleyromo amberleyromo added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Jan 25, 2019
@missmatsuko
Copy link
Contributor

Should this issue be re-opened? I wanted to report an issue with the Showcase screenshots but found #5929 which led me to this epic.

@shannonbux shannonbux reopened this Apr 5, 2019
@shannonbux
Copy link
Contributor Author

All the issues that are closed in this Epic could be reopened too!

@amberleyromo amberleyromo removed their assignment Dec 4, 2019
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Dec 25, 2019
@fk fk removed the stale? Issue that may be closed soon due to the original author not responding any more. label Dec 26, 2019
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 16, 2020
@sidharthachatterjee
Copy link
Contributor

Let's go ahead and close this for now since there aren't any current issues with the Site Showcase. The issue regarding screenshots was most recently fixed in #20427

Thanks everyone!

@missmatsuko
Copy link
Contributor

@sidharthachatterjee That's not true. Non-roman characters still aren't rendering (#5929) and I don't see how the solution in #20427 (expanding Lambda container's space) could possibly fix that.

@missmatsuko missmatsuko reopened this Jan 16, 2020
@LekoArts
Copy link
Contributor

The other issue is describing that so that epic here doesn’t have to stay open :)

@missmatsuko
Copy link
Contributor

missmatsuko commented Jan 16, 2020

What's actually a part of this epic? This issue was previously reopened because #5929 was outstanding so I thought it's part of this epic and the epic should remain open.

@sidharthachatterjee
Copy link
Contributor

@missmatsuko You're absolutely right in that the open issue is part of this epic but

  • We at @gatsbyjs/core don't really use epics anymore
  • Since that's the only issue open, I don't see the point of also keeping this open

Hope that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more.
Projects
None yet
Development

No branches or pull requests

9 participants