-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starter Showcase #5334
Comments
I'd rather keep the source of truth here. For the site showcase, we moved to a YAML file which would great to copy as we can enforce a proper schema. |
ok to be clear the yaml file is just this proposed format https://gist.github.com/fk/5ec0dbdaeb7f4e1839c99b18cbd42332 ? I can give comments there but I think the stuff that can be autogenerated like the plugins list should be autogenerated. real talk tho is the starter showcase just the subset of the site showcase that is open source? (probably not). Is it just the subset of the site showcase that is explicitly tagged with a "starter" category? is it not a subset and a conceptually different thing? I ofc don't want to compete/confuse with anything you're trying to do. I just didn't like the current starter browsing experience. cc @shannonbux for ideas/direction. |
The starter showcase is going to replace the existing starters page. So completely separate from the site showcase — though it'll almost certainly share a lot of design ideas / components. And yeah, that's the format — it's in the repo now at https://github.com/gatsbyjs/gatsby/blob/master/www/src/data/sites.yml |
Exactly what @kylemathews said; the starter and site showcases will be
separate, although the two ought to share design ideas and components (to
save time and create a consistent user experience). Have you checked out
the progress on the site showcase too? This is awesome that you're working
on this, Shawn!!!
…On Wed, May 9, 2018 at 10:22 AM, shawn wang ***@***.***> wrote:
ok to be clear the yaml file is just this proposed format
https://gist.github.com/fk/5ec0dbdaeb7f4e1839c99b18cbd42332 ?
I can give comments there but I think the stuff that can be autogenerated
like the plugins list should be autogenerated.
real talk tho is the starter showcase just the subset of the site showcase
that is open source? (probably not). Is it just the subset of the site
showcase that is explicitly tagged with a "starter" category? is it not a
subset and a conceptually different thing?
I ofc don't want to compete/confuse with anything you're trying to do. I
just didn't like the current starter browsing experience.
cc @shannonbux <https://github.com/shannonbux> for ideas/direction.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5334 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ae9o2tpkVqB6y0SrMwEV3UgqgsHCS9NPks5twyXEgaJpZM4T3Xea>
.
|
ok if the site showcase is more important I'll just put this thing on hold. I think it makes sense to finish one out first and then ctrl+c ctrl+v to the other (obv I have a preference for starting with starter but 🤷♂️ ). I'll comment further on the site showcase issue regarding that stuff. fwiw I did this on my own without even knowing you were doing this work, this is great and I feel the Gatsby docs are coming along very nicely thanks to you both. I don't know that I can commit to significant amounts of time on this. |
Here's a summary of what insights I've gotten from interviewing Gatsby users:
Potential benefits of bringing a site / starter showcase (also based on interviews):
|
Here's the MVP and a few ideas of future enhancements (MVP shares a lot with site showcase w/ a few changes): MVP (minimum viable product)
Nice to have
Very cool, not necessary right away
|
@shannonbux this looks great - I think I can handle a bunch of these. How much do you want to involve Florian or should I just get cracking and stick as close as possible to the Site Showcase design? can looking too similar to the Site Showcase be a problem? |
got started on this today, have the main page up and kinda working, now on the details page |
An idea for a feature (via @hughpearse, #5847) that I couldn't see listed here: add a "Deploy this starter" link or button that publishes the starter to Netlify. @LekoArts noted that this might be redundant in some cases, as starters will often have that button in their |
Here's a rough mock for the index page with a slightly adjusted showcase design including all meta information currently shown at https://gatsby-starter-search.netlify.com/:
|
And another even rougher one for the permalink/detail/modal:
|
I like the simplicity and would suggest not including the tags on the cards. If you filter/search via your tags the result on the right side should speak for itself, especially if you use multiple tags to narrow down the choices.
Looking at your example you see one problem with including the original README: Would be cool to encourage the creators to write an extra description specific to this starter page. |
Hey Lennart, cool you're hanging around here. Appreciate your input! 👍 to not showing tags for each starter card…and yeah, let's go with showing the description from the |
Ah, and to quote myself:
Agree. Moving them between preview image and description would be a good fit I guess. Hover/Dropdown is more like an emergency plan to me. |
just want to point out that im going with individual markdown files for the starters (im being a little bit stubborn about this one for now) instead of a giant yaml file so it is absolutely possible to write the extra description in the body of the markdown file when submitting. was one of my original design goals. i'm going to choose not to care about the duplication problem for now. its something we can deal with after we deploy an mvp |
@fk thinking this through another nice to have would be a "copy to clipboard" feature on both the master and detail pages that copies a |
made more PR's and its basically usable now. needs review from shannon |
hey @LekoArts check out your sites: https://dreamy-shannon-191f15.netlify.com/starter-showcase/?s=lekoarts feedback welcome. |
copying and pasting my notes on remaining polish/todo list - this is a repeat of the internal issue, but may or may not be updated so dont rely on this. just trying to give open source watchers an idea relevant links:
Here are the remaining things from @shannonbux 's requirements lists:
my thoughts on technical things to do:
other ideas:
|
@tsiq-swyx Feedback on what exactly?
|
@LekoArts - i have updated your starters, thanks for reviewing. also did the icons. you can check it again! https://dreamy-shannon-191f15.netlify.com/starter-showcase/?s=lekoarts separately - added version warnings to help prevent people using old starters |
Do you want feedback on the mobile version or are you aware of the issues? I‘d put the Gatsby version in the detail view, not overview. Firstly v1 isn’t outdated yet, secondly even if the starter uses the old version migrating from v1 to v2 isn’t that hard. How about making the repository names also links to the detail view? I always click the name first before realizing that I have to click the image. |
well fwiw I will wait for #5927 to be finished first since I am taking my design cues from there. I had no design spec for mobile at all so didn't spend much time on it. also (personally speaking) mobile view is less important to me because starter showcase is most likely for desktop (so I care more that it "looks fine on mobile" than having full functionality) I think you have a point about the version in detail view. this was something I decided, wasn't in the design spec, and I can easily move it. will discuss with @shannonbux and go with whatever she decides. the reason I put it in overview, is I want to heavily encourage starter maintainers to upgrade to v2. "migrating from v1 to v2 isn't that hard" but I prefer people who are totally new to Gatsby start off on the right foot by using v2. the name thing - ok. easy. |
I'm sure @fk will make a mobile view for reference.
It would be dangerous to ignore mobile users! Most websites have equal mobile traffic or sometimes even more mobile users than desktop users.
It's fine that you want to encourage the maintainers but in my opinion you're telling users (especially with the red color) that these starters are unusable which is not the case. Until v2 is out of beta both versions are equal to me. |
Here's the link to the clickable prototype for mobile I posted a while ago: https://projects.invisionapp.com/share/T9H9LRCG8Z5#/screens/292717380_Index It's also contained within the Sketch file: https://www.dropbox.com/s/9vzatfift5oz69b/gatsbyjs.org%3Ashowcase.v2.sketch |
fwiw Leko i -never- said i was ignoring mobile users :) |
demo: https://gatsby-starter-search.netlify.com/
repo: https://github.com/sw-yx/gatsby-starter-search
related links: #4392
twitter discussion: https://twitter.com/gatsbyjs/status/993954935489282048
I started doing some work on this without knowing there was a Example showcase going on.
(esp didn't know there was a screenshot transformer lol)
this is a rough cut of what I've done. just using an existing design I had lying around, didn't optimize for @fk's beautiful work but I have some nice things like filter by dependencies (can obviously tighten this up a lot but I've only worked on this one afternoon)
edit from the future
the PR into the main docs is here: #6113 (previously #5831)
preview at https://dreamy-shannon-191f15.netlify.com/starter-showcase/
The text was updated successfully, but these errors were encountered: