New API for defining comments inside blocks: Block::add_comment
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 😊 also, thanks for adding the changelog entries. I'll stage a release later. |
|
Released via v2.3.0. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block::itemsused to be aVec<Statement>but we can turn it into aVec<BlockItem>and add support for comments.Note, the spec allows for comments everywhere in source files, not just inside blocks, and this PR only allows comments inside blocks. I don't particularly like that and I'm open to reworking my approach if you have any ideas!
Also added a changelog entry for both this PR as well as #24.