Add support for variadic marker in Instr::Call
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filippo Costa <filippo@neysofu.me>
|
Santa came early! Thanks for the change, really appreciate it! 😊 I'll fix those clippy warnings later, they don't seem to be related to this PR. |
1 task
|
Released via v2.3.0. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't quite fix #4 as that would require changes to
qbe_rs::Functiontoo, but at least this enables calling variadic functions which is nice when interfacing with libc.Thanks for the very handy library, I'm having a blast with it in my hobby project.