Print ping messages taking more than 100 ms #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScheererJ
requested review from
DockToFuture,
marwinski and
axel7born
as code owners
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
the
size/xs
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
axel7born
previously approved these changes
Jun 4, 2024
|
/lgtm |
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
MartinWeindel
requested changes
Jun 4, 2024
shoot-client/path-controller.sh
Outdated
Comment on lines
77
to
78
| ping -W 2 -w 2 -c 1 $ip | sed '/\(^PING.*\|^---.*---$\|.*1 packets received.*\|^round-trip.*\|^$\|.*time=.\?..... ms$\)/d' & | ||
| ping_pid[$ip]=$! |
There was a problem hiding this comment.
I'm no expert for bash scripts, but I have doubts that $! contains the the PID of the ping process.
On Mac I get the PID of the sed instead:
❯ ping -c 1 127.0.0.1 | sed '/\(^PING.*\|^---.*---$\|.*1 packets received.*\|^round-trip.*\|^$\|.*time=.\?..... ms$\)/d' &
[1] 33210 33211
[1] + 33210 done ping -c 1 127.0.0.1 |
33211 done sed
❯ echo $!
33211There was a problem hiding this comment.
Good catch. I reworked the solution based on your input. The approach using post-processing of the ping output works fine.
The following lines are retained:
- packet loss
- roundtrip delays >= 100 ms
2024-06-04 14:43:11 | {"log":"1 packets transmitted, 0 packets received, 100% packet loss"}
...
2024-06-04 14:43:04 | {"log":"64 bytes from 192.168.123.195: seq=0 ttl=64 time=158.881 ms"}
WDYT?
gardener-robot
added
needs/changes
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
axel7born
approved these changes
Jun 4, 2024
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Print ping messages taking more than 100 ms.
In case a ping message in path controller takes more than two seconds the connections is assumed to be broken. However, ICMP messages may get dropped or drowned in a load of traffic. Therefore, it might be interesting to at least see if some messages took longer than usual.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
sedis used instead ofgrepas it is already available in the container.Release note:
/cc @MartinWeindel @rfranzke @axel7born