-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make VPN Network configurable #64
Make VPN Network configurable #64
Conversation
@SimonKienzler Thank you for your contribution. |
Thank you @SimonKienzler for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
/ok-to-test |
@DockToFuture, @marwinski, @ScheererJ, @axel7born You have pull request review open invite, please check |
Hi @SimonKienzler, |
Thanks for looking into it @axel7born - I'll investigate the HA problems as soon as I can, maybe I missed something. |
Hey @axel7born, we had some priority shifts for our next sprint and I won't be able to spend time working on this feature in the next two weeks. Just wanted to let you know, sorry for any inconvenience. If you find time to debug the troubling HA setup, I'd be happy about any pointers you can provide. Otherwise, we'll pick up the investigation and continue this feature again in a few weeks. |
@SimonKienzler what's the status of this PR? Should we hand this one over to a colleague? |
/assign |
I'm unable to edit the PR description. |
@timebertt Command |
@axel7born can you close this PR in favor of #78 and review the new changes there? |
/close this PR in favor of #78 |
What this PR does / why we need it:
In gardener/gardener#8987 we proposed to make the VPN network range configurable. Regardless of how exactly this feature is implemented on the Gardener side (e.g. per Shoot or per Seed), the requirements for the
vpn2
components stay the same: They need to be able to handle an additional environment variable calledVPN_NETWORK
and produce a correct VPN config from its value.This PR introduces some changes to both the
seed-server
and theshoot-client
components to fulfill these requirements.Which issue(s) this PR fixes:
Part of gardener/gardener#8987
Special notes for your reviewer:
VPN_NETWORK
environment variable is not set, the implementation should behave exactly the same as before, ensuring backwards-compatibility.IPv4
networks always have a size of/24
) is now explicitly tested, and the script fails if the network has a different size.shoot-client/path-controller.sh
is used, but assumed that it needs to be adapted just as thenetwork-connection.sh
scripts.go
parts ofvpn2
don't need to be altered for this change. Please advise if I missed something there.Release note: