Introduce gosec for Static Application Security Testing (SAST)
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/compliance
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
G306: Poor file permissions used when writing to a new file
G404: Insecure random number source (rand)
gardener-robot-ci-3
added
reviewed/ok-to-test
G104: Audit errors not checked
gardener-robot-ci-3
added
reviewed/ok-to-test
G204: Audit use of command execution
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
G112: Potential slowloris attack
G114: Use of net/http serve function that has no support for setting timeouts
G108: Profiling endpoint automatically exposed on /debug/pprof `pprof` was automatically enabled as a side effect in the metrics exporter. Now, the metrics exporter has `pprof` properly disabled by using a separate http mux.
gardener-robot
added
size/m
gardener-robot-ci-1
added
the
reviewed/ok-to-test
ScheererJ
requested review from
marwinski,
axel7born and
MartinWeindel
as code owners
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
axel7born
previously approved these changes
Oct 14, 2024
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
reviewed/ok-to-test
ScheererJ
dismissed stale reviews from MartinWeindel and axel7born
via
ca28b0f
gardener-robot
added
needs/review
|
/unhold |
gardener-robot-ci-2
added
the
reviewed/ok-to-test
ScheererJ
removed
the
reviewed/do-not-merge
|
/lgtm |
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
|
/lgtm |
MartinWeindel
approved these changes
Oct 14, 2024
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/area networking
/area security
/area compliance
/kind enhancement
What this PR does / why we need it:
This PR introduces
gosecfor Static Application Security Testing at Gardener and should replace other code scanners.It uses the default ruleset of
gosecfrom gardener/gardener as introduced in gardener/gardener#9959.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Until gardener/gardener#10642 is in a gardener/gardener release there is a small workaround necessary, which will be removed afterwards.
Release note:
/hold
Issues still need to be fixed.