Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.26] Automated cherry pick of #523: Do not fail a request for a Shoot from the core.gardener.cloud/v1alpha1 API #526

Merged
merged 2 commits into from
Nov 30, 2022
Merged

[release-v1.26] Automated cherry pick of #523: Do not fail a request for a Shoot from the core.gardener.cloud/v1alpha1 API #526

merged 2 commits into from
Nov 30, 2022

Conversation

kon-angelo
Copy link
Contributor

/area quality
/kind bug

Cherry pick of #523 on release-v1.26.

#523: Do not fail a request for a Shoot from the core.gardener.cloud/v1alpha1 API

Release Notes:

An issue causing admission-gcp to fail CREATE/UPDATE requests for Shoots from the `core.gardener.cloud/v1alpha1` API is now fixed.

@kon-angelo kon-angelo requested review from a team as code owners November 30, 2022 08:59
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 30, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2022
ialidzhikov
ialidzhikov reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verify step fails with

go: go.mod file indicates go 1.19, but maximum version supported by tidy is 1.18

Otherwise lgtm

@kon-angelo
Copy link
Contributor Author

/reviewed ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2022
@kon-angelo
Copy link
Contributor Author

@ialidzhikov I updated the verify pipeline. It should be consumed with the new version soon.

@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2022
@kon-angelo kon-angelo mentioned this pull request Nov 30, 2022
Closed
MartinWeindel
MartinWeindel approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 30, 2022
@kon-angelo kon-angelo merged commit 98685fa into gardener:release-v1.26 Nov 30, 2022
@kon-angelo kon-angelo deleted the automated-cherry-pick-of-#523-origin-release-v1.26 branch November 30, 2022 10:28
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov left review comments

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kon-angelo @MartinWeindel @ialidzhikov @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot