Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail a request for a Shoot from the core.gardener.cloud/v1alpha1 API #523

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area quality
/kind bug
/platform gcp

What this PR does / why we need it:
Similar to gardener/gardener-extension-provider-aws#657.

Which issue(s) this PR fixes:
See gardener/gardener-extension-provider-aws#657

Release note:

An issue causing admission-gcp to fail CREATE/UPDATE requests for Shoots from the `core.gardener.cloud/v1alpha1` API is now fixed.

@ialidzhikov ialidzhikov requested review from a team as code owners November 25, 2022 13:39
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug platform/gcp Google cloud platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 25, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 25, 2022
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 25, 2022
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 25, 2022
@kon-angelo kon-angelo merged commit 28b18fc into gardener:master Nov 25, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 25, 2022
kon-angelo added a commit that referenced this pull request Nov 30, 2022
…for a Shoot from the core.gardener.cloud/v1alpha1 API (#526)

* Do not fail a request for a Shoot from the core.gardener.cloud/v1alpha1 API

* Clean up unneeded RBAC rule for admission-gcp

admission-gcp does not get/list/watch Shoots

Co-authored-by: ialidzhikov <i.alidjikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants