Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce dns.gardener.cloud/target-hard-ignore annotation #404

Merged
merged 2 commits into from
Dec 13, 2024
Merged

introduce dns.gardener.cloud/target-hard-ignore annotation #404

merged 2 commits into from
Dec 13, 2024

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Dec 12, 2024 •
edited
Loading

What this PR does / why we need it:
If source controller creates a DNSEntry in the target cluster, it is not possible to set the dns.gardener.cloud/ignore annotation on the created DNSEntry. It is overwritten by the source controller to keep it in-sync with the source object.
Therefore a second annotation is introduced dns.gardener.cloud/target-hard-ignore with the similar behaviour. Additionally, the deletion of the DNSEntry is also ignored to make usage future-proof if there are no DNSOwners anymore.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

introduce `dns.gardener.cloud/target-hard-ignore` annotation

@MartinWeindel MartinWeindel requested a review from a team as a code owner December 12, 2024 09:09
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 12, 2024
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 12, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 12, 2024
@marc1404 marc1404 changed the title introduce dns.gardener.cloud/target-ignore annotation introduce dns.gardener.cloud/target-hard-ignore annotation Dec 12, 2024
marc1404
marc1404 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 12, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 12, 2024
@MartinWeindel MartinWeindel merged commit b5f1fd4 into master Dec 13, 2024
12 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 13, 2024
@MartinWeindel MartinWeindel deleted the enh/target-ignore branch December 13, 2024 06:52
@MartinWeindel MartinWeindel mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc1404 marc1404 marc1404 approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinWeindel @marc1404 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot