remove finalizer on deletion for hard ignored entry

gardener · Dec 12, 2024 · d5409d9 · d5409d9
1 parent 078d369
commit d5409d9
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/pkg/dns/provider/state_entry.go b/pkg/dns/provider/state_entry.go
@@ -251,13 +251,18 @@ func (this *state) HandleUpdateEntry(logger logger.LogContext, op string, object
 	}
 
 	if ignored, annotation := ignoredByAnnotation(object); ignored {
-		_, err := object.ModifyStatus(func(data resources.ObjectData) (bool, error) {
-			status := &data.(*api.DNSEntry).Status
-			mod := utils.ModificationState{}
-			mod.AssureStringValue(&status.State, api.STATE_IGNORED)
-			mod.AssureStringPtrPtr(&status.Message, ptr.To(fmt.Sprintf("entry is ignored as annotated with %s", annotation)))
-			return mod.IsModified(), nil
-		})
+		var err error
+		if !object.IsDeleting() {
+			_, err = object.ModifyStatus(func(data resources.ObjectData) (bool, error) {
+				status := &data.(*api.DNSEntry).Status
+				mod := utils.ModificationState{}
+				mod.AssureStringValue(&status.State, api.STATE_IGNORED)
+				mod.AssureStringPtrPtr(&status.Message, ptr.To(fmt.Sprintf("entry is ignored as annotated with %s", annotation)))
+				return mod.IsModified(), nil
+			})
+		} else {
+			err = this.RemoveFinalizer(object)
+		}
 		if err != nil {
 			return reconcile.Delay(logger, err)
 		}