Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick commits 9768494, 5fd33e1 #149

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Cherrypick commits 9768494, 5fd33e1 #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e701cf8
updated dockerfile name and base image
rishabh-11 Jul 29, 2022
3946c12
Set GOOS,GOARCH env and ldflags option in .ci/build file (#147)
himanshu-kun Aug 2, 2022
d1a1496
rollback some cherry-pick changes
rishabh-11 Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .ci/build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,9 @@ fi

# If no LOCAL_BUILD environment variable is set, we configure the `go build` command
# to build for linux OS, amd64 architectures and without CGO enablement.
# ldflags used, same as Makefile , this reduces size of binary considerably
if [[ -z "$LOCAL_BUILD" ]]; then
GO111MODULE=off go build \
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=off go build --ldflags="-s -w" \
-a \
-v \
-o ${BINARY_PATH}/cluster-autoscaler/cluster-autoscaler \
Expand Down
2 changes: 1 addition & 1 deletion cluster-autoscaler/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
ARG BASEIMAGE=gcr.io/distroless/base:latest
ARG BASEIMAGE=gcr.io/distroless/static:latest-amd64
FROM $BASEIMAGE
LABEL maintainer="Marcin Wielgus <mwielgus@google.com>"

Expand Down