Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick commits 9768494, 5fd33e1 #149

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Cherrypick commits 9768494, 5fd33e1 #149

merged 3 commits into from
Aug 3, 2022

Conversation

rishabh-11
Copy link

@rishabh-11 rishabh-11 commented Aug 2, 2022 •
edited by himanshu-kun
Loading

What this PR does / why we need it:
Brings .ci/build in sync with Makefile way of creating binary. This is required as we start using gcr.io/distroless/static:latest-amd64 image in the Dockerfile. The base image in the Dockerfile is brought in sync with the upstream one.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
done only for linux amd-64
Release note:

Updated base image to deal with vulnerabilities

@rishabh-11 rishabh-11 requested review from himanshu-kun, unmarshall and a team as code owners August 2, 2022 17:09
@gardener-robot
Copy link

@rishabh-11 Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 2, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 2, 2022
himanshu-kun
himanshu-kun approved these changes Aug 3, 2022
View reviewed changes
Copy link

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 3, 2022
@himanshu-kun himanshu-kun changed the title Cherrypick commits 9768494 5fd33e1 Cherrypick commits 9768494, 5fd33e1 Aug 3, 2022
@himanshu-kun himanshu-kun merged commit 03ff7f8 into gardener:rel-v1.22 Aug 3, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 3, 2022
@rishabh-11 rishabh-11 deleted the cherrypick-commits-9768494-5fd33e1 branch August 3, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishabh-11 @gardener-robot @himanshu-kun @gardener-robot-ci-3