Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick of #119 #127

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Cherry pick of #119 #127

merged 1 commit into from
Jun 23, 2022

Conversation

himanshu-kun
Copy link

@himanshu-kun himanshu-kun commented Jun 23, 2022 •
edited
Loading

What this PR does / why we need it:
cherry picks changes of #119 onto rel-v1.20
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@himanshu-kun himanshu-kun requested review from hardikdr and a team as code owners June 23, 2022 06:45
@gardener-robot
Copy link

@himanshu-kun You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added needs/rebase Needs git rebase needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 23, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 23, 2022
@himanshu-kun himanshu-kun changed the base branch from machine-controller-manager-provider to rel-v1.20 June 23, 2022 06:45
@himanshu-kun himanshu-kun changed the title Cherry pick of 119 Cherry pick of #119 Jun 23, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 23, 2022
@himanshu-kun himanshu-kun added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase labels Jun 23, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 23, 2022
ashwani2k
ashwani2k approved these changes Jun 23, 2022
View reviewed changes
Copy link

@ashwani2k ashwani2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @himanshu-kun for the PR.
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 23, 2022
@himanshu-kun himanshu-kun merged commit 18bc9ca into gardener:rel-v1.20 Jun 23, 2022
@himanshu-kun himanshu-kun deleted the cherry-pick-pr-119 branch June 23, 2022 08:35
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwani2k ashwani2k ashwani2k approved these changes

@hardikdr hardikdr Awaiting requested review from hardikdr

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@himanshu-kun @gardener-robot @ashwani2k @gardener-robot-ci-1 @gardener-robot-ci-2