Cache not to be used to form node-template during scale from zero #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
NodeTemplate is formed for each nodegroup every time main loop of CA executes. This nodeTemplate is req by CA to perform calculation and finally deciding upon which nodegrp to scale-up. NodeTemplate is formed by 3 options for each nodegrp (in order):
We have a case when a node got created in a sfz nodegrp , but now its not there. Then every other time the cached nodeTemplate is used for that nodegrp. This could be problematic in case when nodeGrp instance type gets updated , because still the nodeTemplate is based on the old instanceType.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
To resolve the above , the nodeTemplate formation from cache has been disabled for nodeGrps with minSize 0 i.e. the ones which would scale from zero. This will cause CA to form nodeTemplate using the machineClass only.
This change is done in the core part of CA which we usually don't touch.
Release note: