Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Implement customizing of etcd stateful sets via webhooks for AWS and GCP #94

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Implement customizing of etcd stateful sets via webhooks for AWS and GCP #94

merged 1 commit into from
Jun 3, 2019

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented May 27, 2019 •
edited by rfranzke
Loading

What this PR does / why we need it:
Adds generic code for customizing etcd stateful sets via webhooks and implements the actual customizing of etcd stateful sets via webhooks for AWS and GCP.

Fixes #55

Special notes for your reviewer:

The code for customizing etcd stateful sets via webhooks is split between 2 types of webhooks:

  • controlplaneexpsure for replacing the default storage class with a non-default one, if configured.
  • controlplanebackup for injecting the backup-restore container.

This PR also:

Release note:

Implement customizing of etcd stateful sets via webhooks for AWS and GCP.

@stoyanr stoyanr requested a review from a team as a code owner May 27, 2019 14:52
@stoyanr stoyanr force-pushed the add-etcd-backup-controlplane-webhooks branch 2 times, most recently from a45f382 to 9963bfb Compare May 27, 2019 15:08
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 27, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 27, 2019
@stoyanr stoyanr force-pushed the add-etcd-backup-controlplane-webhooks branch 2 times, most recently from ce68356 to 23652bd Compare May 29, 2019 08:19
@zanetworker zanetworker self-assigned this May 29, 2019
@stoyanr stoyanr force-pushed the add-etcd-backup-controlplane-webhooks branch from 23652bd to 5f082a7 Compare May 30, 2019 12:30
@stoyanr stoyanr changed the title Implement customizing of etcd stateful sets via webhooks for AWS Implement customizing of etcd stateful sets via webhooks for AWS and GCP May 30, 2019
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 31, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 31, 2019
zanetworker
zanetworker reviewed May 31, 2019
View reviewed changes
Copy link
Contributor

@zanetworker zanetworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @stoyanr, not much comments from my side.

/lgtm

controllers/provider-aws/pkg/apis/config/types.go Show resolved Hide resolved
controllers/provider-aws/pkg/apis/config/types.go Show resolved Hide resolved
@stoyanr stoyanr force-pushed the add-etcd-backup-controlplane-webhooks branch 2 times, most recently from 02805e8 to 87b7660 Compare May 31, 2019 12:43
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 31, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 31, 2019
@stoyanr stoyanr force-pushed the add-etcd-backup-controlplane-webhooks branch from 87b7660 to 0d2e94d Compare May 31, 2019 14:37
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 3, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 3, 2019
@stoyanr stoyanr force-pushed the add-etcd-backup-controlplane-webhooks branch from 0d2e94d to 510f4a5 Compare June 3, 2019 08:10
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 3, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 3, 2019
@stoyanr stoyanr force-pushed the add-etcd-backup-controlplane-webhooks branch from 510f4a5 to 7ce38d0 Compare June 3, 2019 09:25
@stoyanr stoyanr added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 3, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 3, 2019
rfranzke
rfranzke approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 52a19c8 into gardener-attic:master Jun 3, 2019
@stoyanr stoyanr deleted the add-etcd-backup-controlplane-webhooks branch June 3, 2019 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanetworker zanetworker zanetworker left review comments

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stoyanr @zanetworker @rfranzke @gardener-robot-ci-1