Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Implement Controller and Webhook Switches #86

Merged
merged 1 commit into from
May 23, 2019
Merged

Implement Controller and Webhook Switches #86

merged 1 commit into from
May 23, 2019

Conversation

adracus
Copy link
Contributor

@adracus adracus commented May 14, 2019

What this PR does / why we need it:
This allows turning individual controllers / webhooks on and off per command line flag.

Release note:

It is now possible to turn individual webhooks and controllers on and off via the command line flag `--disable-controllers` and `--disable-webhooks`.

@adracus adracus added component/gardener Gardener exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension needs/lgtm Needs approval for merging needs/review Needs review priority/normal Standard backlog priority, that can be worked on now or later size/m A few days of work or medium change status/in-progress Issue is in progress/work topology/seed Affects Seed clusters labels May 14, 2019
@adracus adracus requested a review from a team as a code owner May 14, 2019 17:32
@adracus adracus changed the title Feature.controller switches Implement Controller and Webhook Switches May 14, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 14, 2019
@adracus adracus force-pushed the feature.controller-switches branch from 2d2e106 to 87ddd84 Compare May 14, 2019 17:38
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 14, 2019
@adracus adracus force-pushed the feature.controller-switches branch from 87ddd84 to 079a32e Compare May 15, 2019 10:48
@adracus adracus added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 15, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 15, 2019
rfranzke
rfranzke reviewed May 15, 2019
View reviewed changes
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also allow for all the Helm charts to define these --disabled... flags via their values?

@adracus adracus force-pushed the feature.controller-switches branch from 079a32e to b9ebb69 Compare May 17, 2019 12:52
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 23, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 23, 2019
rfranzke
rfranzke approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit d9aef6c into gardener-attic:master May 23, 2019
@stoyanr stoyanr mentioned this pull request May 27, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
component/gardener Gardener exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/normal Standard backlog priority, that can be worked on now or later size/m A few days of work or medium change status/in-progress Issue is in progress/work topology/seed Affects Seed clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adracus @rfranzke @gardener-robot-ci-1