Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Add controlplane webhooks for Azure #102

Merged

Conversation

mkoynov
Copy link
Contributor

@mkoynov mkoynov commented Jun 4, 2019

What this PR does / why we need it:
Adds controlplane webhooks for Azure

Which issue(s) this PR fixes:
Fixes #54

Special notes for your reviewer:
Completes controlplane controller implementation for the Azure provider. (PR #95)

Release note:

Add controlplane webhooks for Azure

@mkoynov mkoynov requested a review from a team as a code owner June 4, 2019 15:33
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 6, 2019
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! /lgtm

@rfranzke rfranzke added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 6, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 6, 2019
@rfranzke rfranzke merged commit db659cf into gardener-attic:master Jun 6, 2019
@mkoynov mkoynov deleted the add-azure-controlplane-webhooks branch June 13, 2019 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ControlPlane controller for Azure provider
3 participants