This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
Add controlplane for azure provider #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rfranzke
added
the
reviewed/ok-to-test
mkoynov
force-pushed
the
add-azure-controlplane
branch
from
8915655 to
a2d11d7
Compare
gardener-robot-ci-1
added
needs/ok-to-test
stoyanr
previously approved these changes
May 29, 2019
zanetworker
reviewed
May 29, 2019
controllers/provider-azure/example/controller-registration.yaml
Outdated
Show resolved
Hide resolved
controllers/provider-azure/pkg/internal/imagevector/imagevector.go
Outdated
Show resolved
Hide resolved
mkoynov
force-pushed
the
add-azure-controlplane
branch
from
a2d11d7 to
086a1e8
Compare
|
Also please rebase, otherwise /lgtm |
mkoynov
force-pushed
the
add-azure-controlplane
branch
from
086a1e8 to
ee295f2
Compare
Done :) |
rfranzke
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
zanetworker
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds controlplane controller for provider-azure.
Which issue(s) this PR fixes:
Fixes #54
Special notes for your reviewer:
The code follows the same logic as the other providers that has it implemented already.
Release note: