Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase init delay for liveness probe #601

Merged
merged 1 commit into from
Mar 8, 2019
Merged

fix: increase init delay for liveness probe #601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions garden-service/src/plugins/kubernetes/container/deployment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,16 +269,23 @@ function deploymentConfig(service: Service, configuredReplicas: number, namespac

function configureHealthCheck(container, spec): void {

const readinessPeriodSeconds = 1
const readinessFailureThreshold = 90

container.readinessProbe = {
initialDelaySeconds: 10,
periodSeconds: 5,
initialDelaySeconds: 2,
periodSeconds: readinessPeriodSeconds,
timeoutSeconds: 3,
successThreshold: 2,
failureThreshold: 5,
failureThreshold: readinessFailureThreshold,
}

/*
* We wait for the effective failure duration (period * threshold) of the readiness probe before starting the
* liveness probe.
*/
container.livenessProbe = {
initialDelaySeconds: 15,
initialDelaySeconds: readinessPeriodSeconds * readinessFailureThreshold,
periodSeconds: 5,
timeoutSeconds: 3,
successThreshold: 1,
Expand Down