fix: increase init delay for liveness probe #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
reviewed
Mar 7, 2019
edvald
reviewed
Mar 7, 2019
thsig
force-pushed
the
fix-probes
branch
2 times, most recently
from
838da55 to
9f9d2a3
Compare
edvald
approved these changes
Mar 8, 2019
thsig
force-pushed
the
fix-probes
branch
2 times, most recently
from
6801e71 to
df3dc5f
Compare
The initial delay in the liveness probe config for k8s health checks was too short. This was due to the mistaken assumption that k8s would only start running the liveness probe after the readiness probe succeeded. For services that take a long time to start up, the old config would sometimes lead to the liveness probe failing and thus the container being restarted - repeatedly, in some situations. The initial delay and frequency of the readiness probe were also reduced. Later, we should aim to make initialDelaySeconds configurable for the liveness probe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial delay in the liveness probe config for k8s health checks was too short. This was due to the mistaken assumption that k8s would only start running the liveness probe after the readiness probe succeeded.
For services that take a long time to start up, the old config would sometimes lead to the liveness probe failing and thus the container being restarted - repeatedly, in some situations.
The initial delay and frequency of the readiness probe were also reduced.
Later, we should aim to make
initialDelaySecondsconfigurable for the liveness probe.