Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: nicer logging when watching for changes / hot reloading #417

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

edvald
Copy link
Collaborator

@edvald edvald commented Dec 4, 2018

Closes #402 and #237

@drubin
Copy link
Contributor

drubin commented Dec 4, 2018

@edvald The formatting looks a little broken if we make a change to a garden.yml file the gear icon feels like its in the middle of nowhere and the -> don't line up.

Before with no output (it just carries on reloading)
screenshot 2018-12-04 14 55 00

This branch after making a change to garden.yml
screenshot 2018-12-04 14 53 43

This is reproducible in the hot-reload example.

Just run garden-local dev and make a change to any garden.yml file.

@edvald
Copy link
Collaborator Author

edvald commented Dec 4, 2018

Good catch! I'll fix that

@edvald edvald changed the title refactor: nicer logging when watching for changes / hot reloading WIP refactor: nicer logging when watching for changes / hot reloading Dec 4, 2018
@edvald edvald changed the title WIP refactor: nicer logging when watching for changes / hot reloading refactor: nicer logging when watching for changes / hot reloading Dec 6, 2018
@eysi09 eysi09 merged commit 55646b3 into master Dec 6, 2018
@edvald edvald deleted the dev-footer branch April 2, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants