Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log entry for hot reloading is misplaced #402

Closed
thsig opened this issue Nov 30, 2018 · 0 comments
Closed

Log entry for hot reloading is misplaced #402

thsig opened this issue Nov 30, 2018 · 0 comments
Assignees
@edvald
Labels
bug
Milestone
0.8.1

Comments

@thsig
Copy link
Collaborator

thsig commented Nov 30, 2018

This seems to be a regression introduced in #292.

screenshot 2018-11-30 at 08 32 14

The log entry for the hot reload operation at the bottom of the screenshot isn't updated when hot reloading finishes, but instead the updated log entry is rendered above the command header (and the in-progress log entry is still shown with a spinner).
@thsig thsig added the bug label Nov 30, 2018
@eysi09 eysi09 added this to the 0.8.1 milestone Dec 3, 2018
@edvald edvald assigned edvald and unassigned eysi09 Dec 4, 2018
edvald added a commit that referenced this issue Dec 4, 2018
@edvald
refactor: nicer logging when watching for changes / hot reloading
14522a0 
Closes #402 and #237
@edvald edvald mentioned this issue Dec 4, 2018
Merged
edvald added a commit that referenced this issue Dec 4, 2018
@edvald
refactor: nicer logging when watching for changes / hot reloading
25021c2 
Closes #402 and #237
edvald added a commit that referenced this issue Dec 6, 2018
@edvald
refactor: nicer logging when watching for changes / hot reloading
8deb02d 
Closes #402 and #237
edvald added a commit that referenced this issue Dec 6, 2018
@edvald
refactor: nicer logging when watching for changes / hot reloading
b994fe9 
Closes #402 and #237
edvald added a commit that referenced this issue Dec 6, 2018
@edvald
refactor: nicer logging when watching for changes / hot reloading
069a9d0 
Closes #402 and #237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edvald edvald

Labels
bug
Projects
None yet
Milestone
0.8.1
Development

No branches or pull requests
3 participants
@edvald @thsig @eysi09