fix(vcs): include submodules with remote sources #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
approved these changes
Aug 19, 2019
|
Code looks good, but would be great to see some test that directly addresses this if you have time. |
eysi09
force-pushed
the
init-submodules
branch
from
c39e5a7 to
4f3226b
Compare
|
@edvald Updated PR with tests. |
|
Well, aside from the test failures, looks good :) |
eysi09
force-pushed
the
init-submodules
branch
from
4f3226b to
59133aa
Compare
eysi09
force-pushed
the
init-submodules
branch
from
59133aa to
d1ae688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously we didn't initialise submodules for remote sources.
Which issue(s) this PR fixes:
Fixes #463