Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git submodules not initialised with remote modules/sources #463

Closed
eysi09 opened this issue Jan 15, 2019 · 0 comments · Fixed by #1111
Closed

Git submodules not initialised with remote modules/sources #463

eysi09 opened this issue Jan 15, 2019 · 0 comments · Fixed by #1111
Assignees
Labels
bug priority:low Low priority issue or feature
Milestone

Comments

@eysi09
Copy link
Collaborator

eysi09 commented Jan 15, 2019

Bug

Submodules not included with remote sources/modules.

Current Behavior

When importing remote modules/sources via the respositoryUrl directive, submodules are not initialised.

Expected behavior

Submodules should be initialised and work as expected when importing remote modules/sources.

Reproducible example

N/A

Suggested solution(s)

Garden should initial submodules after cloning remote repositories. E.g. with git submodule update --init --recursive.

Furthermore, Garden should update the submodules when garden update-remote source|module is run, e.g. with git submodule update --recursive --remote.

Additional context

This was pointed out as an issue in our community Slack.

Your environment

garden version:

0.8.1

kubectl version

Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.3", GitCommit:"2bba0127d85d5a46ab4b778548be28623b32d0b0", GitTreeState:"clean", BuildDate:"2018-05-21T09:17:39Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.3", GitCommit:"2bba0127d85d5a46ab4b778548be28623b32d0b0", GitTreeState:"clean", BuildDate:"2018-05-21T09:05:37Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

docker version

Client: Docker Engine - Community
 Version:           18.09.0
 API version:       1.39
 Go version:        go1.10.4
 Git commit:        4d60db4
 Built:             Wed Nov  7 00:47:43 2018
 OS/Arch:           darwin/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          18.09.0
  API version:      1.39 (minimum version 1.12)
  Go version:       go1.10.4
  Git commit:       4d60db4
  Built:            Wed Nov  7 00:55:00 2018
  OS/Arch:          linux/amd64
  Experimental:     true
@eysi09 eysi09 added the bug label Jan 15, 2019
@eysi09 eysi09 assigned eysi09 and unassigned eysi09 Jan 15, 2019
@eysi09 eysi09 self-assigned this Jan 25, 2019
@eysi09 eysi09 added this to the 0.9.1 milestone Jan 28, 2019
@eysi09 eysi09 modified the milestones: 0.9.1, 0.9.2 Feb 11, 2019
@eysi09 eysi09 added the priority:medium Medium priority issue or feature label Feb 21, 2019
@eysi09 eysi09 modified the milestones: 0.9.2, 0.9.3 Feb 22, 2019
@eysi09 eysi09 removed this from the 0.9.3 milestone Mar 1, 2019
@eysi09 eysi09 added priority:low Low priority issue or feature and removed priority:medium Medium priority issue or feature labels Aug 12, 2019
@eysi09 eysi09 added this to the v0.10.6 milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug priority:low Low priority issue or feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant