Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add support for runtime config files and env vars #309

Closed
eysi09 opened this issue Sep 27, 2018 · 5 comments
Closed

cli: add support for runtime config files and env vars #309

eysi09 opened this issue Sep 27, 2018 · 5 comments
Assignees
Labels
enhancement stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity.

Comments

@eysi09
Copy link
Collaborator

eysi09 commented Sep 27, 2018

We should support per user and per project CLI runtime configuration files.

User settings could be at $Home/.gardenrc and project settings at /path/to/project/.gardenrc. Among other things, the config files could contain settings for CLI arguments and options. Here's how yarn does it. Other settings could also be added there as applicable.

This would also be a good chance to improve how we handle env variables, it's pretty ad hoc at the moment.

I'm guessing the order of precedence should be:

project settings < user settings  < env vars < cli args 

where cli args has the highest precedence.

@eysi09
Copy link
Collaborator Author

eysi09 commented Oct 8, 2018

@edvald, was the conclusion to implement this in Go?

@edvald
Copy link
Collaborator

edvald commented Oct 8, 2018

That would make sense, since it'll affect behavior at that level.

@eysi09
Copy link
Collaborator Author

eysi09 commented May 2, 2019

See also #668.

@stale
Copy link

stale bot commented Jan 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Jan 15, 2020
@eysi09
Copy link
Collaborator Author

eysi09 commented Jan 19, 2020

Closing in favour of #1523.

@eysi09 eysi09 closed this as completed Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity.
Projects
None yet
Development

No branches or pull requests

3 participants