Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up CLI flags #668

Closed
eysi09 opened this issue Mar 26, 2019 · 0 comments · Fixed by #821
Closed

Clean up CLI flags #668

eysi09 opened this issue Mar 26, 2019 · 0 comments · Fixed by #821
Assignees
@eysi09
Labels
api-change refactor Things that should be cleaned up or refactored, but don't affect users
Milestone
0.10

Comments

@eysi09
Copy link
Collaborator

eysi09 commented Mar 26, 2019

Currently we a silent flag and a --logger-type=quiet flag which both do the same thing. We should probably just skip the latter. We should also consider renaming --loglevel to --log-level.

We should also use the chance to clean up some of the CLI code, make it type safe and improve the way we resolve config (those cases where we have env vars, cli flags and default values for the same thing).
@eysi09 eysi09 added api-change refactor Things that should be cleaned up or refactored, but don't affect users labels Mar 26, 2019
@eysi09 eysi09 mentioned this issue May 2, 2019
Closed
@edvald edvald added this to the 0.10 milestone May 30, 2019
@eysi09 eysi09 self-assigned this Jun 4, 2019
@eysi09 eysi09 mentioned this issue Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eysi09 eysi09

Labels
api-change refactor Things that should be cleaned up or refactored, but don't affect users
Projects
None yet
Milestone
0.10
Development

Successfully merging a pull request may close this issue.

Cli updates garden-io/garden
2 participants
@edvald @eysi09