Incorrect fancy logger type rendering in Terminal.app

[jmeickle]

Bug

Current Behavior

The braille-based spinner (and several other "fancy" features) don't render properly in terminal.app

Note: I don't see this issue on an npm update for example, which also uses similar spinners and in-place terminal updates

Expected behavior

I don't have to run --logger-type=basic with every command :(

Your environment

[eronarn@ip-192-168-10-243 qf]$ garden version && kubectl version && docker version
0.10.2
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.3", GitCommit:"5e53fd6bc17c0dec8434817e69b04a25d8ae0ff0", GitTreeState:"clean", BuildDate:"2019-06-06T01:44:30Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.7", GitCommit:"4683545293d792934a7a7e12f2cc47d20b2dd01b", GitTreeState:"clean", BuildDate:"2019-06-06T01:39:30Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}
Client: Docker Engine - Community
 Version:           19.03.0-rc2
 API version:       1.40
 Go version:        go1.12.5
 Git commit:        f97efcc
 Built:             Wed Jun  5 01:37:53 2019
 OS/Arch:           darwin/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.0-rc2
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.12.5
  Git commit:       f97efcc
  Built:            Wed Jun  5 01:42:10 2019
  OS/Arch:          linux/amd64
  Experimental:     true
 containerd:
  Version:          v1.2.6
  GitCommit:        894b81a4b802e4eb2a91d1ce216b8817763c29fb
 runc:
  Version:          1.0.0-rc8
  GitCommit:        425e105d5a03fabd737a126ad93d62a9eeede87f
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

In case it helps, here's a redacted version of my env vars with stuff that might be relevant to terminals:

TERM_PROGRAM=Apple_Terminal
TERM=xterm-256color
SHELL=/bin/bash
TERM_PROGRAM_VERSION=388.1.1
_system_type=Darwin
rvm_path=/Users/eronarn/.rvm
SSH_AUTH_SOCK=/private/tmp/com.apple.launchd.nUAor3vxpT/Listeners
__CF_USER_TEXT_ENCODING=0x1F5:0x0:0x0
LANG=en_US.UTF-8
_system_arch=x86_64
PS1=\[\]\[\][\u@\h \W]\$ \[\]
_system_version=10.12
SHLVL=1
_system_name=OSX

[jmeickle]

Some additional context here:

One, this makes a lot of commands pretty much unusable without appending a --logger-type=basic. So while technically everything still works I'd classify this as a major usability bug.

Two, there doesn't seem to be a user-global .gardenrc or the like where I could set my logger type (or if it exists I cannot find it). I would expect this to be an option, and for garden options to describe how to set such a file up.

[eysi09]

Hi @Eronarn

You can use the GARDEN_LOGGER_TYPE env var to turn off the fancy logger. E.g.: export GARDEN_LOGGER_TYPE=basic.

I'm travelling today but I'll look into this first thing tomorrow.

And in general, we want to add support for user profiles via something like .gardenrc. There's an old issue for this (#309) and this has also come up in the context of remote sources (#952).

[jmeickle]

Just confirming that this did work for me with the new release 👍