Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let mkversionheader.sh detect presence of git and git repos #660

Merged

Conversation

fingolfin
Copy link
Member

This is an alternative to PR #492 (which was already merged into master). Without it, GAP 4.8.3 will print incorrect versions when compiled inside a surrounding git repository. E.g. if you extract GAP in your home directory, but your homedirectory is a git repository. Or if you build GAP inside sage. Or if you build GAP using my "GAP for Mac OS X" tool chain. Etc.

This is different from PR #492 because the change there was actually slightly incorrect (as a result, GAP on the master branch is back to printing "unknown" as its version).

This PR targets stable-4.8 because I actually think it would be quite desirable to have this in 4.8.3, and it has a low-risk: the worst that can happen is that a wrong version of GAP is printed; but the point of this patch is to fix such issues in various instances. On the upside, it is used only in a very specific and isolated way, so testing it is fairly easy.

@fingolfin fingolfin added this to the GAP 4.8.3 milestone Mar 8, 2016
@ChrisJefferson
Copy link
Contributor

This looks good to me, and should only mess up the git version at worst anyway.

ChrisJefferson added a commit that referenced this pull request Mar 10, 2016
Let mkversionheader.sh detect presence of git and git repos
@ChrisJefferson ChrisJefferson merged commit 2e4b215 into gap-system:stable-4.8 Mar 10, 2016
@fingolfin fingolfin deleted the mh/fix-mkversionheader branch August 18, 2016 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants